On Fri, Jan 11, 2013 at 08:33:23PM +0200, Rémi Denis-Courmont wrote:
> --- a/configure
> +++ b/configure
> @@ -1616,6 +1617,7 @@ mpeg2_dxva2_hwaccel_select="dxva2 mpeg2video_decoder"
>  mpeg2_vaapi_hwaccel_select="vaapi mpeg2video_decoder"
>  mpeg2_vdpau_hwaccel_select="vdpau mpeg2video_decoder"
>  mpeg4_vaapi_hwaccel_select="vaapi mpeg4_decoder"
> +mpeg4_vdpau_hwaccel_select="vdpau mpeg4_decoder"
>  mpeg4_vdpau_decoder_select="vdpau mpeg4_decoder"
>  vc1_dxva2_hwaccel_deps="dxva2api_h"
>  vc1_dxva2_hwaccel_select="dxva2 vc1_decoder"

order

> --- /dev/null
> +++ b/libavcodec/vdpau_mpeg4.c
> @@ -0,0 +1,110 @@
> +
> +#include "avcodec.h"
> +#include "dsputil.h"
> +#include "vdpau_internal.h"
> +
> +#include <assert.h>

Does this #include work as expected?  I suspect that NDEBUG may have
been fiddled with already in some of our local headers..

> +    /* fill VdpPictureInfoMPEG4Part2 struct */
> +    info->forward_reference                 = VDP_INVALID_HANDLE;
> +    info->backward_reference                = VDP_INVALID_HANDLE;
> +    info->vop_coding_type                   = 0;

nit: spacing

> +    switch (s->pict_type) {
> +    case AV_PICTURE_TYPE_B:
> +        ref = ff_vdpau_get_surface_id(&s->next_picture);
> +        assert(ref != VDP_INVALID_HANDLE);
> +        info->backward_reference     = ref;
> +        info->vop_coding_type        = 2;
> +        /* fall-through */
> +    case AV_PICTURE_TYPE_P:
> +        ref = ff_vdpau_get_surface_id(&s->last_picture);
> +        assert(ref != VDP_INVALID_HANDLE);
> +        info->forward_reference      = ref;
> +    }

nit: ditto

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to