On 12/01/13 17:49, Alexandra Khirnova wrote:
> From: Joakim Plate <[email protected]>
>
> This is how mkvs store palette information for vobsubs
> ---
First
libavcodec/dvdsubdec.c: In function ‘decode_dvd_subtitles’:
libavcodec/dvdsubdec.c:157:28: warning: ‘colormap[0]’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
libavcodec/dvdsubdec.c:181:13: note: ‘colormap[0]’ was declared here
libavcodec/dvdsubdec.c:157:28: warning: ‘colormap[1]’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
libavcodec/dvdsubdec.c:181:13: note: ‘colormap[1]’ was declared here
libavcodec/dvdsubdec.c:157:28: warning: ‘colormap[2]’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
libavcodec/dvdsubdec.c:181:13: note: ‘colormap[2]’ was declared here
libavcodec/dvdsubdec.c:157:28: warning: ‘colormap[3]’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
libavcodec/dvdsubdec.c:181:13: note: ‘colormap[3]’ was declared here
Looks bad, the simplest way to avoid it is to initialize the colormap
(and alpha) to { 0 }
Second my review comes late in form of patch for further work upon it.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
