On Sat, 12 Jan 2013, Daniel Kang wrote:

> -    mova   [rsp+ 0], m0
> -    mova   [rsp+16], m3
> -    mova   [rsp+32], m1
> +    mova   [rsp- 0], m0
> +    mova   [rsp-16], m3
> +    mova   [rsp-32], m1

You can't do that on x86_32.

> +%assign PAD -1*80

Unused?

>  %macro YADIF 0
> -cglobal yadif_filter_line, 7, 7, 8, 16*5, dst, prev, cur, next, w, prefs, \
> -                                          mrefs, parity, mode
> -    test             wq, wq
> +cglobal yadif_filter_line, 4, 7, 8, PAD

Do you have a reason for removing all the named args?

> +    cmp DWORD r4m, 0
>      jle .ret
> -    movsxdifnidn prefsq, prefsd
> -    movsxdifnidn mrefsq, mrefsd
> +%if ARCH_X86_32
> +    movifnidn  r4, r5mp
> +    movifnidn  r5, r6mp
> +    DECLARE_REG_TMP 4,5
> +%else
> +    movsxdifnidn r5, DWORD r5m
> +    movsxdifnidn r6, DWORD r6m
> +    DECLARE_REG_TMP 5,6
> +%endif

No ifnidn. After your change, they will not in fact be identical.

--Loren Merritt
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to