On 14/01/13 20:02, Martin Storsjö wrote: > On Mon, 14 Jan 2013, Luca Barbato wrote: > >> On 14/01/13 19:12, Martin Storsjö wrote: >>> This supports the AES_CM_128_HMAC_SHA1_80 and >>> AES_CM_128_HMAC_SHA1_32 cipher suites (from RFC 4568) at the >>> moment. The main missing features are replay protection (which can be >>> added later without changing the internal API), and the F8 and null >>> ciphers. >>> --- >>> libavformat/srtp.c | 291 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> libavformat/srtp.h | 50 +++++++++ >>> 2 files changed, 341 insertions(+) >>> create mode 100644 libavformat/srtp.c >>> create mode 100644 libavformat/srtp.h >> >> Looks ok, if you could go over it and change -1 to AVERRORS and 14 and >> friends defines would be great. > > Changed to use AVERROR_*. The constant numbers are for a number of > things (maximum number of bytes added when encrypting a packet, or the > number of bytes used as master salt (in the currently supported ciphers) > or other things as well, replacing it with a define right away isn't > that useful. If we extend it to support other cipher suites, some of > them will probably be refactored into context variables instead, so > changing straight into defines doesn't help all that much. >
Fine as is then. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
