On Monday, January 14, 2013, Martin Storsjö <[email protected]> wrote: > On Mon, 14 Jan 2013, Sean McGovern wrote: > >> Several of the options were incorrect for suncc. >> Let's just shove the GCC options through >> the pre-existing compiler flags filter. >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index e9cdfab..da56349 100755 >> --- a/configure >> +++ b/configure >> @@ -3882,7 +3882,7 @@ LD_PATH=$LD_PATH >> DLLTOOL=$dlltool >> LDFLAGS=$LDFLAGS >> LDFLAGS-avserver=$AVSERVERLDFLAGS >> -SHFLAGS=$SHFLAGS >> +SHFLAGS=$(echo $($ldflags_filter $SHFLAGS)) >> YASMFLAGS=$YASMFLAGS >> BUILDSUF=$build_suffix >> FULLNAME=$FULLNAME >> -- >> 1.8.0.2 > > Do I recall correctly if the extra $(echo) is to get rid of the newlines at the end? It could be good to mention this in the commit message (but no need to resend just for that).
Yes, that's exactly what it does. Committer has my permission to add that comment. > FWIW, I tested the MSVC DLL build with this patch applied, and it didn't change anything there - it could be good to test it with other odd compilers where we support shared libs as well. Awesome, thanks Martin. :) -- Sean McG.
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
