On Mon, 14 Jan 2013, Diego Biurrun wrote:
On Mon, Jan 14, 2013 at 10:36:08PM +0200, Martin Storsjö wrote:
On Mon, 14 Jan 2013, Diego Biurrun wrote:
We do not enable warnings about unused function parameters, so
there is little point in trying to silence those warnings.
Besides, some fringe compilers choke on these attributes.
---
This is a more complete version of Rémi's patch.
libavcodec/dxva2_h264.c | 3 +--
libavcodec/dxva2_mpeg2.c | 4 ++--
libavcodec/dxva2_vc1.c | 3 +--
libavcodec/vaapi_h264.c | 6 +++---
libavcodec/vaapi_mpeg2.c | 4 +++-
libavcodec/vaapi_mpeg4.c | 4 +++-
libavcodec/vaapi_vc1.c | 3 ++-
libavcodec/vda_h264.c | 4 ++--
libavcodec/vdpau.c | 3 +--
libavcodec/vdpau_internal.h | 4 ++--
libavcodec/vdpau_mpeg4.c | 6 +++---
11 files changed, 23 insertions(+), 21 deletions(-)
Umm, no. Sure, we don't have these annotations everywhere, and we
don't warn about it by default, but removing isn't necessary either.
Why do you want to keep them in just a few select places? We probably
have dozens or hundreds of functions with unused parameters...
Why not keep it? We've got av_unused for normal variables all over the
place, and someone has chosen to add these parameters here as well.
Removing it just because we don't have it consistently just feels like
nitpicking. If you'd happen to be building in a configuration or with a
compiler that warns for this by default, you'll have a few warnings less,
which to me is a good thing.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
