On Fri, Jan 18, 2013 at 02:16:01PM -0800, Ronald S. Bultje wrote: > On Fri, Jan 18, 2013 at 2:05 PM, Diego Biurrun <[email protected]> wrote: > > --- a/libavcodec/h264idct_template.c > > +++ b/libavcodec/h264idct_template.c > > @@ -27,25 +27,7 @@ > > > > #include "bit_depth_template.c" > > #include "libavutil/common.h" > > - > > -#ifndef AVCODEC_H264IDCT_INTERNAL_H > > -#define AVCODEC_H264IDCT_INTERNAL_H > > -//FIXME this table is a duplicate from h264data.h, and will be removed > > once the tables from, h264 have been split > > -static const uint8_t scan8[16*3]={ > > - 4+ 1*8, 5+ 1*8, 4+ 2*8, 5+ 2*8, > > - 6+ 1*8, 7+ 1*8, 6+ 2*8, 7+ 2*8, > > - 4+ 3*8, 5+ 3*8, 4+ 4*8, 5+ 4*8, > > - 6+ 3*8, 7+ 3*8, 6+ 4*8, 7+ 4*8, > > - 4+ 6*8, 5+ 6*8, 4+ 7*8, 5+ 7*8, > > - 6+ 6*8, 7+ 6*8, 6+ 7*8, 7+ 7*8, > > - 4+ 8*8, 5+ 8*8, 4+ 9*8, 5+ 9*8, > > - 6+ 8*8, 7+ 8*8, 6+ 9*8, 7+ 9*8, > > - 4+11*8, 5+11*8, 4+12*8, 5+12*8, > > - 6+11*8, 7+11*8, 6+12*8, 7+12*8, > > - 4+13*8, 5+13*8, 4+14*8, 5+14*8, > > - 6+13*8, 7+13*8, 6+14*8, 7+14*8 > > -}; > > -#endif > > +#include "h264.h" > > And this changes the binary size by how much? (IIRC that was the > reason this hack was introduced.)
before: biurrun@passion:/opt/biurrun/libav $ ls -l libavcodec/h264idct.o -rw-rw-r-- 1 biurrun src-pisa 139648 2013-01-18 22:45 libavcodec/h264idct.o biurrun@passion:/opt/biurrun/libav $ size libavcodec/h264idct.o text data bss dec hex filename 40184 0 0 40184 9cf8 libavcodec/h264idct.o biurrun@passion:/opt/biurrun/libav $ ls -l libavcodec/libavcodec.a -rw-rw-r-- 1 biurrun src-pisa 71582716 2013-01-18 22:46 libavcodec/libavcodec.a biurrun@passion:/opt/biurrun/libav $ size --totals libavcodec/libavcodec.a 6762675 90142 4966094 11818911 b4579f (TOTALS) after: biurrun@passion:/opt/biurrun/libav $ ls -l libavcodec/h264idct.o -rw-rw-r-- 1 biurrun src-pisa 139336 2013-01-18 22:53 libavcodec/h264idct.o biurrun@passion:/opt/biurrun/libav $ size libavcodec/h264idct.o text data bss dec hex filename 40187 0 0 40187 9cfb libavcodec/h264idct.o biurrun@passion:/opt/biurrun/libav $ ls -l libavcodec/libavcodec.a -rw-rw-r-- 1 biurrun src-pisa 71582404 2013-01-18 22:53 libavcodec/libavcodec.a biurrun@passion:/opt/biurrun/libav $ size --totals libavcodec/libavcodec.a 6762678 90142 4966094 11818914 b457a2 (TOTALS) I think there is some other way to correctly measure binary size that I am forgetting right now. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
