Hi,

On Sat, Jan 19, 2013 at 10:21 AM, Xi Wang <[email protected]> wrote:
> The loop condition `x = ex' is incorrect.  It should be `x <= ex'.
>
> This bug was introduced in commit c65dfac4 "mpegvideo.c: K&R formatting
> and cosmetics."
>
> Signed-off-by: Xi Wang <[email protected]>
> ---
>  libavcodec/mpegvideo.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c
> index 5bb04dd..ce36610 100644
> --- a/libavcodec/mpegvideo.c
> +++ b/libavcodec/mpegvideo.c
> @@ -1659,7 +1659,7 @@ static void draw_line(uint8_t *buf, int sx, int sy, int 
> ex, int ey,
>          buf += sx + sy * stride;
>          ex  -= sx;
>          f    = ((ey - sy) << 16) / ex;
> -        for (x = 0; x = ex; x++) {
> +        for (x = 0; x <= ex; x++) {
>              y  = (x * f) >> 16;
>              fr = (x * f) & 0xFFFF;
>              buf[y * stride + x]       += (color * (0x10000 - fr)) >> 16;
> --
> 1.7.10.4

That looks ok, lgtm.

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to