On Mon, Jan 21, 2013 at 10:45:44AM -0800, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <[email protected]>
> 
> ---
>  configure                     |  7 ++++---
>  libavcodec/Makefile           |  1 +
>  libavcodec/dsputil.c          |  1 -
>  libavcodec/dsputil.h          |  2 --
>  libavcodec/dsputil_template.c |  4 ----
>  libavcodec/vp3.c              |  5 ++++-
>  libavcodec/vp35mcdsp.c        | 43 
> +++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vp35mcdsp.h        | 43 
> +++++++++++++++++++++++++++++++++++++++++++
>  libavcodec/vp56.c             |  3 ++-
>  libavcodec/vp56.h             |  2 ++
>  10 files changed, 99 insertions(+), 12 deletions(-)
>  create mode 100644 libavcodec/vp35mcdsp.c
>  create mode 100644 libavcodec/vp35mcdsp.h

You don't touch the optimized version below libavcodec/x86/ - why?

> --- /dev/null
> +++ b/libavcodec/vp35mcdsp.h
> @@ -0,0 +1,43 @@
> +
> +#ifndef AVCODEC_VP35MCDSP_H
> +#define AVCODEC_VP35MCDSP_H
> +
> +#include <stddef.h>
> +
> +typedef struct VP35MCDSPContext {
> +    void (*put_no_rnd_pixels_l2)(uint8_t *dst,
> +                                 const uint8_t *a,
> +                                 const uint8_t *b,
> +                                 ptrdiff_t stride, int h);

Add stdint.h for the POSIX int types, I suspect this will fail
"make checkheaders" otherwise.

> --- a/libavcodec/vp56.c
> +++ b/libavcodec/vp56.c
> @@ -373,7 +373,7 @@ static void vp56_mc(VP56Context *s, int b, int plane, 
> uint8_t *src,
>              s->filter(s, dst, src_block, src_offset, 
> src_offset+overlap_offset,
>                        stride, s->mv[b], mask, s->filter_selection, b<4);
>          else
> -            s->dsp.put_no_rnd_pixels_l2(dst, src_block+src_offset,
> +            s->vp35mcdsp.put_no_rnd_pixels_l2(dst, src_block+src_offset,
>                                          src_block+src_offset+overlap_offset,
>                                          stride, 8);

Please fix the indentation.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to