On 21/01/13 22:29, Diego Biurrun wrote:
> +void ff_diracdsp_init(DiracDSPContext *c, AVCodecContext *avctx)
> +{
> + ff_dsputil_init(&c->dsp, avctx);
> What do you need this for, we're trying to drop dsputil dependencies.
I use some functions that are reachable through dspcontext like
draw_edges as well as the put/get_tpel_pixels_tab_(l2/4)_8 ones. Should
I move them into diracdsp.c?
>
>> + // checkme: bitdepth set to 8 but could bitdepth be variable?
>> + ff_videodsp_init(&c->videodsp, 8);
> Is avctx->bits_per_raw_sample set? Then you could use that value.
No it is not set but I can set it in dirac_decode_init() although I'm
not sure if that parameter can change dynamically.
> What do you need the DSPContext for? Can it be dropped?
If we replicate the mentioned functions or they are moved to other place
reachable from diracdec.c and diracdsp.c, then we can drop it.
--
Jordi Ortiz
[email protected]
http://www.jordiortiz.es
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
