On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: > On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun <[email protected]> wrote: > > It does not help as an abstraction and adds dsputil dependencies. > > I like the commit. I do want to add, though, that you're not actually > practically removing the dsputil dependency from a lot of files (at > build time), even though the dependency is (in a code-sense) no longer > there. Examples are in vp3.c or vp8.c, but there's likely more.
Your comment puzzles me. vp3.c directly uses DSPContext, vp8.c has no dependency on dsputil, before or after my patch ... What I did do was push dsputil.h #includes out to the leaves of the dependency graph. An example of this is prores. I dropped the dsputil.h #include from proresdsp.h, but added it to proresdsp.c, proresdec.c and proresenc.c. All three .c files directly use symbols from dsputil.h, so they relied on dsputil.h being provided to them via proresdsp.h. Thus the real dependency count was not increased by three, but reduced from four files to three. This reliance on indirect inclusion is also the reason I sent the ARM patch that adds a few required headers (and is a prerequisite for this patch). Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
