Hi, On Tue, Jan 22, 2013 at 7:11 AM, Ronald S. Bultje <[email protected]> wrote: > Hi, > > On Tue, Jan 22, 2013 at 4:00 AM, Diego Biurrun <[email protected]> wrote: >> On Mon, Jan 21, 2013 at 06:02:38PM -0800, Ronald S. Bultje wrote: >>> >>> --- a/libavcodec/dsputil.h >>> +++ b/libavcodec/dsputil.h >>> @@ -281,15 +281,15 @@ typedef struct DSPContext { >>> >>> /** >>> * Halfpel motion compensation with no rounding (a+b)>>1. >>> - * this is an array[2][4] of motion compensation functions for 2 >>> - * horizontal blocksizes (8,16) and the 4 halfpel positions<br> >>> - * *pixels_tab[ 0->16xH 1->8xH ][ xhalfpel + 2*yhalfpel ] >>> + * this is an array[4] of motion compensation functions for 1 >>> + * horizontal blocksizes (16) and the 4 halfpel positions<br> >>> + * *pixels_tab[0][ xhalfpel + 2*yhalfpel ] >> >> one horizontal blocksize_ >> >>> - op_pixels_func avg_no_rnd_pixels_tab[4][4]; >>> + op_pixels_func avg_no_rnd_pixels_tab[1][4]; >> >> Why do you keep this array two-dimensional? > > This is currently stuck in dsputil's macro mess. I'm looking into ways > of fixing that (while also fixing some other oddities) but I'm not > quite ready with that yet. Basically, it will be fixed in a later > commit.
This is now fixed in a separate commit. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
