On Thu, Jan 24, 2013 at 06:41:38PM +0100, Janne Grunau wrote:
> The code was copied from per cpu extension init function so the checks
> for supported extensions was overlooked.
> ---
> libavcodec/x86/h264_qpel.c | 139
> ++++++++++++++++++++++++---------------------
> 1 file changed, 74 insertions(+), 65 deletions(-)
>
> --- a/libavcodec/x86/h264_qpel.c
> +++ b/libavcodec/x86/h264_qpel.c
> @@ -534,85 +535,93 @@ void ff_h264qpel_init_x86(H264QpelContext *c, int
> bit_depth)
> int mm_flags = av_get_cpu_flags();
>
> #if HAVE_MMXEXT_EXTERNAL
> - if (!high_bit_depth) {
> - SET_QPEL_FUNCS(put_h264_qpel, 0, 16, mmxext, );
> - SET_QPEL_FUNCS(put_h264_qpel, 1, 8, mmxext, );
> - } else if (bit_depth == 10) {
> + if (EXTERNAL_MMXEXT(mm_flags)) {
> + if (!high_bit_depth) {
> + SET_QPEL_FUNCS(put_h264_qpel, 0, 16, mmxext, );
> + SET_QPEL_FUNCS(put_h264_qpel, 1, 8, mmxext, );
All those #if are unneeded, you just need to wrap the body of the
function in HAVE_YASM. Patch coming up ...
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
