On 26/01/13 01:32, Diego Biurrun wrote:
> On Fri, Jan 25, 2013 at 02:58:42PM +0100, Luca Barbato wrote:
>> Mirrors the one avcodec.
>
> This is ungrammatical, either "Mirrors the one in libavcodec." or
> "Mirrors the one libavcodec has."
Both are fine. Thanks =)
>
>> --- a/libavformat/avformat.h
>> +++ b/libavformat/avformat.h
>> @@ -1042,6 +1042,13 @@ typedef struct AVFormatContext {
>> */
>> #define RAW_PACKET_BUFFER_SIZE 2500000
>> int raw_packet_buffer_remaining_size;
>> +
>> + /**
>> + * strictly follow the standard.
>> + * - encoding: Set by user.
>> + * - decoding: Set by user.
>> + */
>> + int strict_std_compliance;
>> } AVFormatContext;
>
> I notice that the rest of the file does it, but encoding/decoding should
> really be muxing/demuxing ...
I guess I should fix avformat fix the =)
>
>> --- a/libavformat/options_table.h
>> +++ b/libavformat/options_table.h
>> @@ -57,6 +57,12 @@ static const AVOption options[]={
>> {"bitstream", "detect bitstream specification deviations", 0,
>> AV_OPT_TYPE_CONST, {.i64 = AV_EF_BITSTREAM }, INT_MIN, INT_MAX, D,
>> "err_detect"},
>> {"buffer", "detect improper bitstream length", 0, AV_OPT_TYPE_CONST, {.i64
>> = AV_EF_BUFFER }, INT_MIN, INT_MAX, D, "err_detect"},
>> {"explode", "abort decoding on minor error detection", 0,
>> AV_OPT_TYPE_CONST, {.i64 = AV_EF_EXPLODE }, INT_MIN, INT_MAX, D,
>> "err_detect"},
>> +{"strict", "how strictly to follow the standards",
>> OFFSET(strict_std_compliance), AV_OPT_TYPE_INT, {.i64 = DEFAULT }, INT_MIN,
>> INT_MAX, D|E, "strict"},
>> +{"very", "strictly conform to a older more strict version of the spec or
>> reference software", 0, AV_OPT_TYPE_CONST, {.i64 = FF_COMPLIANCE_VERY_STRICT
>> }, INT_MIN, INT_MAX, D|E, "strict"},
>
> an older
I guess I should fix that on avcodec first.
Patch on hold till I do not cleanup those then. Opinions on the
functionality meanwhile?
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
