Am 06.02.2013 17:27, schrieb Daniel Kang:
> On Tue, Feb 5, 2013 at 1:23 PM, Diego Biurrun <[email protected]> wrote:
>> On Fri, Feb 01, 2013 at 06:28:30PM -0500, Daniel Kang wrote:
>>> --- a/libavcodec/x86/dsputil.asm
>>> +++ b/libavcodec/x86/dsputil.asm
>>> @@ -648,3 +650,160 @@ BSWAP32_BUF
>>> +
>>> +INIT_MMX mmx
>>> +cglobal h263_v_loop_filter, 3,5
>>> +    movsxdifnidn r1, r1
>>> +    movsxdifnidn r2, r2
>>> +
>>> +INIT_MMX mmx
>>> +cglobal h263_h_loop_filter, 3,5,0,32
>>> +    movsxdifnidn r1, r1
>>> +    movsxdifnidn r2, r2
>> Is the sign extension still needed after all the ptrdiff_t changes I did?
> Yes. You didn't touch h263 loop filter, either that or your changes
> haven't been pushed.
>
movsxdifnidn r1, r1
doesn't do anything. Probably should be
movsxdifnidn r1, r1d
movsxdifnidn r2, r2d

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to