---
See the following IRC discussion:
00:48 <@DonDiego> libavcodec/rectangle.h: assert((((long)vp)&(FFMIN(w,
STRIDE_ALIGN)-1)) == 0);
00:48 <@DonDiego> how much sense does that asser make?
00:50 <@DonDiego> it is the only use of STRIDE_ALIGN outside of
libavcodec/utils.c
01:21 <+astrange> hmm. if fill_rectangle was optimized for PPC that would make
sense
01:21 <+astrange> because if someone wrote unaligned fill_rectangle code we'd
get silent data corruption without the assert
01:22 <+astrange> but right now it's not helpful and with theoretical SSE code
it would crash in an easily identifiable way
This allows dropping another piece off of dsputil.h.
libavcodec/rectangle.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/rectangle.h b/libavcodec/rectangle.h
index 5cc81fe..f18f667 100644
--- a/libavcodec/rectangle.h
+++ b/libavcodec/rectangle.h
@@ -47,7 +47,6 @@ static av_always_inline void fill_rectangle(void *vp, int w,
int h, int stride,
w *= size;
stride *= size;
- assert((((long)vp)&(FFMIN(w, STRIDE_ALIGN)-1)) == 0);
assert((stride&(w-1))==0);
if(w==2){
const uint16_t v= size==4 ? val : val*0x0101;
--
1.7.9.5
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
