On 02/12/2013 08:01 AM, Alexandra Khirnova wrote: > --- > libavcodec/vmdav.c | 140 > ++++++++++++++++++++++------------------------------ > 1 file changed, 59 insertions(+), 81 deletions(-) > > diff --git a/libavcodec/vmdav.c b/libavcodec/vmdav.c > index cffc00a..25df7e0 100644 > --- a/libavcodec/vmdav.c > +++ b/libavcodec/vmdav.c
I just have a general comment about the patch. Why so many manual checks? Especially since it's not returning an error for overflows, it could just check once per loop iteration. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
