On Sun, 17 Feb 2013 09:43:32 +0100, Reinhard Tartler <[email protected]> wrote: > From: Michael Niedermayer <[email protected]> > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > Signed-off-by: Michael Niedermayer <[email protected]> > (cherry picked from commit 3ae610451170cd5a28b33950006ff0bd23036845) > > Signed-off-by: Michael Niedermayer <[email protected]> > (cherry picked from commit fee26d352a52eb9f7fcd8d9167fb4a5ba015b612) > > Signed-off-by: Reinhard Tartler <[email protected]> > --- > libavcodec/roqvideodec.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c > index 2543cec..ef62758 100644 > --- a/libavcodec/roqvideodec.c > +++ b/libavcodec/roqvideodec.c > @@ -159,6 +159,12 @@ static av_cold int roq_decode_init(AVCodecContext *avctx) > RoqContext *s = avctx->priv_data; > > s->avctx = avctx; > + > + if (avctx->width%16 || avctx->height%16) { > + av_log(avctx, AV_LOG_ERROR, "dimensions not being a multiple of 16 > are unsupported\n"); > + return AVERROR_PATCHWELCOME; > + }
Broken indentation, missing spaces around %, too long av_log line. Also the message wording is weird, I'd write something like "Dimensions must be a multiple of 16" Otherwise should be fine. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
