On Mon, Feb 18, 2013 at 9:21 AM, Diego Biurrun <[email protected]> wrote: > On Mon, Feb 18, 2013 at 09:08:35AM -0500, Daniel Kang wrote: >> Specifically related to the H263 encoder/decoder. >> --- >> libavcodec/x86/dsputil.asm | 4 ++++ >> 1 file changed, 4 insertions(+) > > Note that it's linking, not a compilation failure. > >> --- a/libavcodec/x86/dsputil.asm >> +++ b/libavcodec/x86/dsputil.asm >> @@ -727,6 +727,7 @@ BSWAP32_BUF >> INIT_MMX mmx >> ; void h263_v_loop_filter(uint8_t *src, int stride, int qscale) >> cglobal h263_v_loop_filter, 3,5 >> +%if CONFIG_H263_DECODER || CONFIG_H263_ENCODER >> movsxdifnidn r1, r1d >> movsxdifnidn r2, r2d >> >> @@ -745,6 +746,7 @@ cglobal h263_v_loop_filter, 3,5 >> mova [r0], m4 >> mova [r4], m5 >> mova [r0+r1], m6 >> +%endif >> RET >> >> %macro TRANSPOSE4X4 2 >> @@ -769,6 +771,7 @@ cglobal h263_v_loop_filter, 3,5 >> ; void h263_h_loop_filter(uint8_t *src, int stride, int qscale) >> INIT_MMX mmx >> cglobal h263_h_loop_filter, 3,5,0,32 >> +%if CONFIG_H263_DECODER || CONFIG_H263_ENCODER >> movsxdifnidn r1, r1d >> movsxdifnidn r2, r2d >> >> @@ -810,4 +813,5 @@ cglobal h263_h_loop_filter, 3,5,0,32 >> movd [r4+r1*2], m6 >> punpckhdq m6, m6 >> movd [r4+r3], m6 >> +%endif >> RET > > Can't you move the H.263 code to a separate file? That would be much > cleaner than this ifdeffery.
A cleaner solution would be to just remove this from dsputil since it's only called in h263 specific contexts, but that falls outside the scope of my work. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
