On Thu, 21 Feb 2013, Diego Biurrun wrote:

On Wed, Feb 20, 2013 at 02:02:06PM +0200, Martin Storsjö wrote:
On Wed, 20 Feb 2013, Diego Biurrun wrote:
On Mon, Feb 11, 2013 at 11:54:22PM +0100, Diego Biurrun wrote:
On Mon, Feb 11, 2013 at 10:38:24PM +0200, Martin Storsjö wrote:
On Mon, 11 Feb 2013, Diego Biurrun wrote:

---

... and now w/o brown paperbag bugs ...

What was the bug, forgetting to add host_cppflags to CMDLINE_APPEND,
anything else?

Nothing else.  I hacked this up on the train w/o finishing it, then
sent it when Derek pinged his patchset, forgetting that it was not
yet finished...

So patch OK?

I don't see anything obviously wrong with it, but I'd rather hold
off pushing it until some actual features that use it are done, so
that I can test it in context.

A valid use case already exists: Try compiling on a Cygwin or MinGW
host with --enable-hardcoded-tables.  It will fail, but work with
--host-cppflags=-U__STRICT_ANSI__.

Right. I guess this patch is ok then.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to