On Tue, Mar 12, 2013 at 01:19:24PM +0100, Diego Biurrun wrote: > On Tue, Mar 12, 2013 at 12:48:26PM +0100, Anton Khirnov wrote: > > --- a/libavcodec/h264.h > > +++ b/libavcodec/h264.h > > @@ -59,7 +59,7 @@ > > #define MAX_SLICES 16 > > > > #ifdef ALLOW_INTERLACE > > -#define MB_MBAFF h->mb_mbaff > > +#define MB_MBAFF(h) h->mb_mbaff > > #define MB_FIELD h->mb_field_decoding_flag > > #define FRAME_MBAFF h->mb_aff_frame > > Why change only one of those macros? > > > #define FIELD_PICTURE (h->picture_structure != PICT_FRAME) > > @@ -68,7 +68,7 @@ > > #define LBOT 1 > > #define LEFT(i) (i) > > #else > > -#define MB_MBAFF 0 > > +#define MB_MBAFF(h) 0 > > #define MB_FIELD 0 > > #define FRAME_MBAFF 0 > > Please maintain alignment in both cases.
Scratch these comments, I had not looked at the rest of the set yet ... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
