On 13/03/13 13:15, Vittorio Giovara wrote: > On Thu, Feb 21, 2013 at 10:31 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > >> The "problem" is that avframe would have some kind of side data and that >> would been looking up on the side data array for the right type. (see >> the branch to have a look on how it is done there and let's discuss if >> it too slow for you, even if it should not) >> >> lu >> >> >> So, I have sent three patches on this topic, adding a new type in lavu and > parsing h264 metadata. > Right now I've added a field in avcodeccontext and have it updated at the > end of the SEI parsing. > I plan to implement signalling preserving when transcoding to libx264 and > some info log ouput. >
More details in the review, I'd consider those issues: - if the information come from SEI it is variable on frame level. - adding fields in the codec context is wrong if we are talking about metadata. - I'd try using the new frame-metadata api instead. Question: - is it something that is codec-specific or could be signaled from the container. (e.g. a container for raw-pixel frames would keep the information somewhere else but not the stream itself)? lu _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
