On Wed, Mar 27, 2013 at 12:11:59PM +0200, Martin Storsjö wrote:
> This fixes standalone compilation of the msmpeg4v2, msmpeg4v3
> and wmv2 encoders, that previously failed to link due to the
> decoder codepaths requiring error_resilience.

LGTM

> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -244,17 +244,17 @@ OBJS-$(CONFIG_MPEG1VIDEO_DECODER)      += mpeg12.o 
> mpeg12data.o
>  OBJS-$(CONFIG_MPEG2VIDEO_ENCODER)      += mpeg12enc.o mpeg12.o
> -OBJS-$(CONFIG_MSMPEG4V1_DECODER)       += msmpeg4.o msmpeg4data.o
> +OBJS-$(CONFIG_MSMPEG4V1_DECODER)       += msmpeg4.o msmpeg4data.o 
> msmpeg4dec.o

nit: Please add msmpeg4dec.o to the front of the list.  The object
files are mostly sorted by dependency order, i.e. decoder -> common
code -> data tables, where "->" denotes the link time dependencies.

same below

Patch OK either way.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to