On Wed, Mar 27, 2013 at 4:36 PM, Derek Buitenhuis <[email protected]> wrote: > On 2013-03-26 9:08 AM, Martin Storsjö wrote: >> From: Reimar Döffinger <[email protected]> >> >> In order to match Linux behaviour better our Windows-specific >> open() replacement should disable Windows default file locking. >> --- > > [...] > >> - fd = _wopen(filename_w, oflag, pmode); >> + fd = _wsopen(filename_w, oflag, SH_DENYNO, pmode); >> av_freep(&filename_w); >> >> /* filename maybe be in CP_ACP */ >> if (fd == -1 && !(oflag & O_CREAT)) >> - return open(filename_utf8, oflag, pmode); >> + return _sopen(filename_utf8, oflag, SH_DENYNO, pmode); > > According to MSDN[1], you're supposed to lock the bytes[2] before > reading them if you used shared opening. Do we address this anywhere? > > - Derek > > [1] http://msdn.microsoft.com/en-us/library/w7sa2b22.aspx (See "Example") > [2] http://msdn.microsoft.com/en-us/library/8054ew2f.aspx
While the Example does point to the second page, in no words does it say that you're supposed to do that, unless i'm terribly blind again? - Hendrik _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
