On Thu, Apr 11, 2013 at 03:44:49PM +0200, Nicolas Bertrand wrote: > --- > tests/fate/video.mak | 3 +++ > tests/ref/fate/jpeg2000-dcinema-xyz | 3 +++ > 2 files changed, 6 insertions(+) > create mode 100644 tests/ref/fate/jpeg2000-dcinema-xyz > > diff --git a/tests/fate/video.mak b/tests/fate/video.mak > index cad7644..09a4966 100644 > --- a/tests/fate/video.mak > +++ b/tests/fate/video.mak > @@ -154,6 +154,9 @@ fate-interplay-mve-16bit: CMD = framecrc -i > $(SAMPLES)/interplay-mve/descent3-le > FATE_SAMPLES_AVCONV-$(call DEMDEC, MXF, JPEG2000) += fate-jpeg2000-dcinema > fate-jpeg2000-dcinema: CMD = framecrc -i > $(SAMPLES)/jpeg2000/chiens_dcinema2K.mxf > > +FATE_SAMPLES_AVCONV-$(call DEMDEC, MXF, JPEG2000) += > fate-jpeg2000-dcinema-xyz > +fate-jpeg2000-dcinema-xyz: CMD = framecrc -i > $(SAMPLES)/jpeg2000/chiens_dcinema2K.mxf -vf xyz2rgb
Refactor these two tests if you add another for JPEG2000: FATE_JPEG2000 += fate-jpeg2000-dcinema fate-jpeg2000-dcinema: CMD = framecrc -i $(SAMPLES)/jpeg2000/chiens_dcinema2K.mxf FATE_JPEG2000 += fate-jpeg2000-dcinema-xyz fate-jpeg2000-dcinema-xyz: CMD = framecrc -i $(SAMPLES)/jpeg2000/chiens_dcinema2K.mxf -vf xyz2rgb FATE_SAMPLES_AVCONV-$(call DEMDEC, MXF, JPEG2000) += $(FATE_JPEG2000) But semantically, the question remains what you are really testing here: the JPEG 2000 decoder or the xyz filter. If the intention is to test the decoder with the filter, the location is fine. If the intention is to test the filter (and use a JPEG 2000 file just by coincidence), then this test belongs in filter.mak. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
