On Fri, Apr 12, 2013 at 01:08:23AM +0300, Martin Storsjö wrote: > On Thu, 11 Apr 2013, Diego Biurrun wrote: > > >--- > >libavcodec/x86/h264_qpel.c | 13 ++++++++----- > >1 file changed, 8 insertions(+), 5 deletions(-) > > > >diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c > >index f909825..2d1c443 100644 > >--- a/libavcodec/x86/h264_qpel.c > >+++ b/libavcodec/x86/h264_qpel.c > >@@ -28,17 +28,20 @@ > >#include "dsputil_mmx.h" > > > >#if HAVE_YASM > >-void ff_put_pixels4_mmxext(uint8_t *block, const uint8_t *pixels, int > >line_size, int h); > >-void ff_avg_pixels4_mmxext(uint8_t *block, const uint8_t *pixels, int > >line_size, int h); > >-void ff_put_pixels8_mmxext(uint8_t *block, const uint8_t *pixels, int > >line_size, int h); > >+void ff_put_pixels4_mmxext(uint8_t *block, const uint8_t *pixels, > >+ ptrdiff_t line_size, int h); > >+void ff_avg_pixels4_mmxext(uint8_t *block, const uint8_t *pixels, > >+ ptrdiff_t line_size, int h); > >+void ff_put_pixels8_mmxext(uint8_t *block, const uint8_t *pixels, > >+ ptrdiff_t line_size, int h); > > I guess this is a missed part of 25841dfe? Thus it should be ok I guess... > > The same C function signature in qpel.asm should be updated as well > (that one also seems to be missed),
Fixed locally. > and the movsxdifnidn could be dropped there. But that conflicts with > the hpeldsp patchset, so I'd rather postpone that to after that > patchset is in. IIUC we can drop all or most of those movsxdifnidn. But I agree it's better to do after the patchset, possibly all in one go. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
