On Fri, 12 Apr 2013 10:25:37 +0200, Diego Biurrun <[email protected]> wrote: > On Tue, Apr 09, 2013 at 11:13:32PM +0200, Nicolas Bertrand wrote: > > --- > > Changelog | 1 + > > doc/general.texi | 4 +- > > libavcodec/Makefile | 2 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/avcodec.h | 6 + > > libavcodec/jpeg2000.c | 459 +++++++++++++++++ > > libavcodec/jpeg2000.h | 267 ++++++++++ > > libavcodec/jpeg2000dec.c | 1269 > > ++++++++++++++++++++++++++++++++++++++++++++++ > > libavcodec/jpeg2000dwt.c | 263 ++++++++++ > > libavcodec/jpeg2000dwt.h | 62 +++ > > libavcodec/mqc.c | 112 ++++ > > libavcodec/mqc.h | 74 +++ > > libavcodec/mqcdec.c | 93 ++++ > > 13 files changed, 2611 insertions(+), 2 deletions(-) > > create mode 100644 libavcodec/jpeg2000.c > > create mode 100644 libavcodec/jpeg2000.h > > create mode 100644 libavcodec/jpeg2000dec.c > > create mode 100644 libavcodec/jpeg2000dwt.c > > create mode 100644 libavcodec/jpeg2000dwt.h > > create mode 100644 libavcodec/mqc.c > > create mode 100644 libavcodec/mqc.h > > create mode 100644 libavcodec/mqcdec.c > > A version bump is missing (fixed locally). > > > --- /dev/null > > +++ b/libavcodec/jpeg2000.h > > @@ -0,0 +1,267 @@ > > +static inline int ff_jpeg2000_getrefctxno(int flag) > > +{ > > + static const uint8_t refctxno_lut[2][2] = { { 14, 15 }, { 16, 16 } }; > > + return refctxno_lut[(flag >> 14) & 1][(flag & 255) != 0]; > > +} > > A static table within a header is not good; it will get duplicated at > every place this header is #included. Can we move this one out? >
Not worth the effort for such a small table -- it's just 4 bytes. The function code will be more than that. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
