On Wed, Apr 10, 2013 at 07:24:37PM +0300, Martin Storsjö wrote: > diff --git a/libavcodec/alpha/dsputil_alpha.c > b/libavcodec/alpha/hpeldsp_alpha.c > similarity index 70% > copy from libavcodec/alpha/dsputil_alpha.c > copy to libavcodec/alpha/hpeldsp_alpha.c > index 34fe2eb..1f1699f 100644 > --- a/libavcodec/alpha/dsputil_alpha.c > +++ b/libavcodec/alpha/hpeldsp_alpha.c > @@ -19,106 +19,10 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 > USA > */ > > -#include "libavutil/attributes.h" > -#include "libavcodec/dsputil.h" > -#include "dsputil_alpha.h" > +#include "libavcodec/hpeldsp.h" > +#include "hpeldsp_alpha.h" > #include "asm.h"
attributes.h should be kept. > diff --git a/libavcodec/bfin/vp3_bfin.h b/libavcodec/alpha/hpeldsp_alpha.h > similarity index 76% > copy from libavcodec/bfin/vp3_bfin.h > copy to libavcodec/alpha/hpeldsp_alpha.h > index 5a2c5a4..304cf2c 100644 > --- a/libavcodec/bfin/vp3_bfin.h > +++ b/libavcodec/alpha/hpeldsp_alpha.h > @@ -16,12 +16,12 @@ > > - > -#ifndef AVCODEC_BFIN_VP3_BFIN_H > -#define AVCODEC_BFIN_VP3_BFIN_H > +#ifndef AVCODEC_ALPHA_HPELDSP_ALPHA_H > +#define AVCODEC_ALPHA_HPELDSP_ALPHA_H Haha, git detected a funny copy :D > #include <stdint.h> > > -void ff_bfin_vp3_idct(int16_t *block); > +void put_pixels_axp_asm(uint8_t *block, const uint8_t *pixels, > + ptrdiff_t line_size, int h); stddef.h for ptrdiff_t > --- /dev/null > +++ b/libavcodec/alpha/hpeldsp_alpha_asm.S > @@ -0,0 +1,135 @@ > + > +#include "regdef.h" > + > +/* Some nicer register names. */ > +#define ta t10 > +#define tb t11 > +#define tc t12 > +#define td AT > +/* Danger: these overlap with the argument list and the return value */ > +#define te a5 > +#define tf a4 > +#define tg a3 > +#define th v0 These defines are duplicated. I think they could be moved to regdef.h. LGTM otherwise. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
