On Fri, Apr 19, 2013 at 10:38:46AM +0200, Nicolas BERTRAND wrote:
> Le 18/04/2013 19:06, Diego Biurrun a écrit :
> >>+/* FIXME: Why use 1.625732422 instead of 1/F_LFTG_K?
> >>>+ * see (ISO/IEC 15444:1 (version 2002) F.3.8.2 */
> >Hmmmm...
> >
> Yes Hmmm. The value wrong in jpeg2000 norm.... This the reason of my
> previous wrong IDWT
> 
> >>>@@ -231,8 +327,11 @@ int ff_jpeg2000_dwt_init(DWTContext *s, uint16_t 
> >>>border[2][2],
> >>>      case FF_DWT97:
> >>>          s->linebuf = av_malloc((maxlen + 12) * sizeof(float));
> >>>          break;
> >>>+     case FF_DWT97_INT:
> >>>+        s->linebuf = av_malloc((maxlen + 12) * sizeof(int32_t));
> >>>+        break;
> >>>      case FF_DWT53:
> >>>-        s->linebuf = av_malloc((maxlen + 6) * sizeof(int));
> >>>+        s->linebuf = av_malloc((maxlen +  6) * sizeof(int32_t));
> >These sizeofs should better be sizeof(*var) than sizeof(type).
> So for that I have to create local variables just for sizeof?

of course not
s->linebuf = av_malloc((maxlen +  6) * sizeof(*s->linebuf));
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to