On Mon, 22 Apr 2013, Luca Barbato wrote:

On 04/22/2013 02:07 PM, Diego Biurrun wrote:

-static int ff_sctp_recvmsg(int s, void *msg, size_t len, struct sockaddr *from,
-                           socklen_t *fromlen, struct sctp_sndrcvinfo *sinfo,
-                           int *msg_flags)
+static int sctp_recvmsg(int s, void *msg, size_t len, struct sockaddr *from,
+                        socklen_t *fromlen, struct sctp_sndrcvinfo *sinfo,
+                        int *msg_flags)
 {
     int recvb;
     struct iovec iov;
@@ -112,8 +112,8 @@ static int ff_sctp_recvmsg(int s, void *msg, size_t len, 
struct sockaddr *from,
     return recvb;
 }

-static int ff_sctp_send(int s, const void *msg, size_t len,
-                        const struct sctp_sndrcvinfo *sinfo, int flags)
+static int sctp_send(int s, const void *msg, size_t len,
+                     const struct sctp_sndrcvinfo *sinfo, int flags)

You should avoid that since those functions are defined in the sctp header.

They got moved there verbatim to avoid a pointless dependency to the
library containing those two functions.

Yes, this patch leads to the following build error:

libavformat/sctp.c:73:12: error: static declaration of ‘sctp_recvmsg’ follows non-static declaration /usr/include/netinet/sctp.h:852:5: note: previous declaration of ‘sctp_recvmsg’ was here libavformat/sctp.c:115:12: error: static declaration of ‘sctp_send’ follows non-static declaration /usr/include/netinet/sctp.h:844:5: note: previous declaration of ‘sctp_send’ was here

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to