On Sat, Apr 20, 2013 at 12:18:57AM +0300, Martin Storsjö wrote: > --- a/libavcodec/x86/hpeldsp_rnd_template.c > +++ b/libavcodec/x86/hpeldsp_rnd_template.c > @@ -24,6 +24,8 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 > USA > */ > > +#include "dsputil_rnd_template.c"
Hmmm, so this patch is OK in the sense that it stops the source-level duplication, which is already a great step. However, it does nothing to stop the duplication at the object level. dsputil_rnd_template.c contains a bunch of static function templates, which end up in both hpeldsp_init.c and dsputil_mmx.c. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
