On Sun, 5 May 2013, Diego Biurrun wrote:

The function is only instantiated once, so there is no point
in keeping it in a template file.
---
libavcodec/x86/dsputil_mmx.h          |    3 +++
libavcodec/x86/fpel_mmx.c             |   21 +++++++++++++++++++++
libavcodec/x86/hpeldsp_init.c         |    3 +--
libavcodec/x86/hpeldsp_rnd_template.c |   22 ----------------------
4 files changed, 25 insertions(+), 24 deletions(-)

Doesn't this make the function be built and included anywhere where fpel_mmx is included (e.g. in a build with dsputil enabled but not hpeldsp)? Wouldn't it make more sense to keep it in a hpeldsp file, if that's the only place where it's used?

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to