On 05/16/2013 09:22 PM, Martin Storsjö wrote: > From: Jeremy Hinegardner <[email protected]> > > According to the PIFF specification[1] the base_data_offset field MUST be > omitteed. See section 5.2.17. Since the ISMV files created by ffmpeg state > that they are 'piff' compatible via 'ftyp' box, this needs to be corrected. > > [1] > http://www.iis.net/learn/media/smooth-streaming/protected-interoperable-file-format > --- > libavformat/movenc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 496158c..4ed99b7 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -2189,9 +2189,11 @@ static int mov_write_tfhd_tag(AVIOContext *pb, > MOVTrack *track, > > /* Don't set a default sample size, the silverlight player refuses > * to play files with that set. Don't set a default sample duration, > - * WMP freaks out if it is set. */ > + * WMP freaks out if it is set. Don't set a base data offset, PIFF > + * file format says it MUST NOT be set. */ > if (track->mode == MODE_ISM) > - flags &= ~(MOV_TFHD_DEFAULT_SIZE | MOV_TFHD_DEFAULT_DURATION); > + flags &= ~(MOV_TFHD_DEFAULT_SIZE | MOV_TFHD_DEFAULT_DURATION | > + MOV_TFHD_BASE_DATA_OFFSET); > > avio_wb32(pb, 0); /* size placeholder */ > ffio_wfourcc(pb, "tfhd"); >
I'd amend the commit message a little, the patch itself looks correct. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
