On Thu, 16 May 2013, Alex Smith wrote:
While the current one works and it's unlikely it would cause any trouble it's probably a good idea to use a slightly less generic string to grep against. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/configure b/configure index 7bcaac3..cbde7c0 100755 --- a/configure +++ b/configure @@ -2525,7 +2525,7 @@ probe_cc(){ _cflags_size="-O2 -Munroll=c:1 $opt_common" _cflags_noopt="-O1" _flags_filter=pgi_flags - elif $_cc 2>&1 | grep -q Microsoft; then + elif $_cc 2>&1 | grep -q 'Microsoft (R) \(32-bit \)\?C/C++ Optimizing Compiler'; then _type=msvc _ident=$($cc 2>&1 | head -n1) _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' -- 1.8.1.msysgit.1
While the current one obviously is pretty generic, the new one on the other hand might feel a bit narrow as well - chances are that it won't match upcoming versions directly. What about VS2013 which apparently is out for beta already? But if others like this, I don't mind.
// Martin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
