On Fri, 17 May 2013, Diego Biurrun wrote:
On 05/17/2013 04:20 PM, Martin Storsjö wrote:MSVC 2010 (or more precisely, Windows SDK 7.0 which comes with MSVC 2010) sets _WIN32_WINNT to the constant for Windows 7 if nothing is set. This could lead to the libav configure script detecting and using functions only present in Windows 7 or newer, which in most cases isn't desired. If the caller explicitly wants this, the caller can add the _WIN32_WINNT define via --extra-cflags, setting the desired version. --- a/configure +++ b/configure @@ -3197,6 +3197,7 @@ elif check_func_headers stdlib.h _get_doserrno; then add_compat msvcrt/snprintf.o snprintf=avpriv_snprintf \ _snprintf=avpriv_snprintf \ vsnprintf=avpriv_vsnprintf+ check_cpp_condition stdlib.h "defined(_WIN32_WINNT)" || add_cppflags -D_WIN32_WINNT=0x0502IMO this warrants a comment in the code about what you are trying to accomplish. For example, I can never remember which _WIN32_WINNT version corresponds to which Windows release.
I amended the patch locally with a comment much in the same style as the commit message.
I also amended the default version to 0x0501 (which is XP, while 0x0502 is Windows Server 2003).
// Martin
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
