On 05/17/2013 09:03 PM, Anton Khirnov wrote: > > On Fri, 17 May 2013 20:40:06 +0200, Luca Barbato <[email protected]> wrote: >> On 05/17/2013 07:15 PM, Tim W. wrote: >>> On May 17, 2013, at 3:26 PM, Luca Barbato <[email protected]> wrote: >>> >>>> A library should not crash on purpose. >>>> --- >>>> >>>> I find dangerous leaving them around, the performance loss is negligible >>>> probably, but leaving them around on release build feels wrong nonetheless. >>> >>> +10000 >>> >> >> I might consider purging the whole codebase out of them... Who is against? > > I am. > > asserts are good when used properly.
So only when developing something, not when releasing. Leaving active asserts in release builds is horrible. > Though feel free to replace them with av_assert Some of them should be converted to proper checks with return values. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
