On 2013-05-15 20:57:42 +0900, Yusuke Nakamura wrote:
> 2013/5/8 Yusuke Nakamura <[email protected]>
>
> From ef78ded8954c3fca0ed138b29ee22dfe5a42fb2a Mon Sep 17 00:00:00 2001
> From: Yusuke Nakamura <[email protected]>
> Date: Wed, 15 May 2013 07:36:15 +0900
> Subject: [PATCH 1/2] avcodec: Add picture structure information to
> AVCodecParserContext.
>
> ---
> libavcodec/avcodec.h | 7 +++++++
> libavcodec/version.h | 2 +-
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 968f9e5..87a80fa 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -3539,6 +3539,13 @@ typedef struct AVCodecParserContext {
> int duration;
>
> enum AVFieldOrder field_order;
> +
> + /**
> + * A picture coded as which frame coded, or top or bottom field coded.
> + * Set to 0 for frame coded or unknown, 1 for top field coded and
> + * 2 for bottom field coded.
> + */
> + int picture_structure;
> } AVCodecParserContext;
I would have added AV_FIELD_TOP_ONLY and AV_FIELD_BOTTOM_ONLY to
enum AVFieldOrder and used field_order but adding picture struct is ok
too and slightly more correct.
Please use an enum for picture_structure though and the comment needs a
better description. Maybe ask Diegon on irc.
An entry in doc/APIchanges would be nice
> typedef struct AVCodecParser {
> diff --git a/libavcodec/version.h b/libavcodec/version.h
> index 2dc0f4d..afc2d35 100644
> --- a/libavcodec/version.h
> +++ b/libavcodec/version.h
> @@ -27,7 +27,7 @@
> */
>
> #define LIBAVCODEC_VERSION_MAJOR 55
> -#define LIBAVCODEC_VERSION_MINOR 4
> +#define LIBAVCODEC_VERSION_MINOR 5
> #define LIBAVCODEC_VERSION_MICRO 0
>
> #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \
> --
> 1.7.7.msysgit.1
>
> From 17d22387d912975a4ab7c995efb7521abcb0fea3 Mon Sep 17 00:00:00 2001
> From: Yusuke Nakamura <[email protected]>
> Date: Wed, 15 May 2013 07:37:36 +0900
> Subject: [PATCH 2/2] h264_parser: Set field_order and picture_structure.
>
> ---
> libavcodec/h264.c | 12 +++++-----
> libavcodec/h264.h | 1 +
> libavcodec/h264_parser.c | 53
> ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 60 insertions(+), 6 deletions(-)
This is ok but needs an update after picture_structure is an enum
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
