On 2013-05-24 09:07, Anton Khirnov wrote:
---
libavfilter/avfilter.h | 104 +++++++++++++++++++++++++++++++++++++++---------
1 file changed, 86 insertions(+), 18 deletions(-)
Good work, this looks good, a few comments below ..
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
@@ -438,29 +460,71 @@ typedef struct AVFilter {
/**
- * Should be set instead of init by the filters that want to pass a
- * dictionary of AVOptions to nested contexts that are allocated in
- * init.
+ * Should be set instead of @ref AVFilter.init "init" by the filters that
+ * want to pass a dictionary of AVOptions to nested contexts that are
+ * allocated in init.
I'd say "during init" instead of "in init".
+ * On return, the options dict should be freed and replaced with one that
+ * contains all the options which could not be processed by this filter (or
+ * with NULL if all the options are processed).
I think it should be s/are processed/were processed/ here.
/**
+ * Filter uninitialization function.
+ *
+ * Called only once right before the filter is freed. Should deallocate any
+ * memory held by the filter, release any buffer references, etc. This does
+ * not need to deallocate the AVFilterContext.priv memory itself.
s/This does not/It does not/
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
