On 05/27/2013 10:17 AM, Kostya Shishkov wrote: > On Mon, May 27, 2013 at 05:05:54PM +0300, Martin Storsjö wrote: >> On Mon, 27 May 2013, Kostya Shishkov wrote: >> >>> Smacker audio uses overflows instead of clipping. >>> >>> This reverts commit 375ca0aca81be2951d9ba4731196e70e490d3cdf. >>> --- >>> libavcodec/smacker.c | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> Probably ok, given that we've got a sample that is fixed by this >> patch, but nobody could find a sample that gets broken by it. > > I've also found one 8-bit sample that was broken by clipping in very visible > way (Settlers II Gold English intro) too. And original Smacker decoder does > not have clipping either.
I would add a comment in the code so nobody else later tries to fix the integer overflows. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
