On 2013-05-28 14:37, Luca Barbato wrote:
On 5/28/13 2:28 PM, Martin Storsjö wrote:
The object file format doesn't support PIC loads in ARM assembly,
there are no relocation types in PE/COFF that correspond to
BFD_RELOC_32_PCREL (R_ARM_REL32 in ELF).
--- a/configure
+++ b/configure
@@ -3386,7 +3386,8 @@ EOF
      check_inline_asm asm_mod_q '"add r0, %Q0, %R0" :: "r"((long
long)0)'
      check_inline_asm asm_mod_y '"vmul.i32 d0, d0, %y0" :: "x"(0)'

-    enabled_all armv6t2 shared !pic && enable_weak_pic
+    [ $target_os = win32 ] ||
+        { enabled_all armv6t2 shared !pic && enable_weak_pic; }

  elif enabled mips; then

maybe turn it around to

enabled_all armv6t2 shared !pic && [ $target_os != win32 ] &&
enable_weak_pic

not sure which is more readable though.

The latter is more readable, it combines && conditions only.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to