On 06/15/2013 03:00 PM, Diego Biurrun wrote:
> On 2013-06-15 12:12, Luca Barbato wrote:
>> ---
>>   libavformat/Makefile   |   1 +
>>   libavformat/internal.h |  36 ------------
>>   libavformat/url.c      | 146
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>>   libavformat/url.h      |  37 +++++++++++++
>>   libavformat/utils.c    | 113 --------------------------------------
>>   5 files changed, 184 insertions(+), 149 deletions(-)
>>   create mode 100644 libavformat/url.c
> 
> I suspect this would need more #include changes to account for the moved
> functions...

Luckily no =)

>> --- /dev/null
>> +++ b/libavformat/url.c
>> @@ -0,0 +1,146 @@
>> +/*
>> + * url utility functions
> 
> URL
> 
>> +#include "avformat.h"
>> +#include "internal.h"
>> +#include "libavutil/avstring.h"
>> +#include "url.h"
>> +#if CONFIG_NETWORK
>> +#include "network.h"
>> +#endif
> 
> config.h is missing and libavutil could be moved up.

I'd rather move it down, but yes, an explicit config.h is better.

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to