On Tue, Jun 18, 2013 at 11:19:53AM +0200, Anton Khirnov wrote:
> 'filter' is too generic, since the functions in question deals with
> several filters.
> 
> Also add const qualifiers to those variables.
> ---
>  avconv_filter.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/avconv_filter.c b/avconv_filter.c
> index da8949c..af5e13f 100644
> --- a/avconv_filter.c
> +++ b/avconv_filter.c
> @@ -413,7 +413,7 @@ static int configure_input_video_filter(FilterGraph *fg, 
> InputFilter *ifilter,
>                                          AVFilterInOut *in)
>  {
>      AVFilterContext *first_filter = in->filter_ctx;
> -    AVFilter *filter = avfilter_get_by_name("buffer");
> +    const AVFilter *buffer = avfilter_get_by_name("buffer");

Well, "buffer" makes one think about some array or a part of rail coupling
system but not filter (even if it's its name). Maybe use 'buffilt' instead?
</bikeshed>
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to