On 2013-06-20 08:09, Hendrik Leppkes wrote:
On Thu, Jun 20, 2013 at 2:12 AM, Diego Biurrun <[email protected]> wrote:
On 2013-06-20 00:07, Alex Smith wrote:
Instead, since it is implied by O1 or O2, selectively disable frame
pointer omission for x86 debug builds. Oy is ignored for x64 targets.
This also silences warnings with icl targeting x64.
--- a/configure
+++ b/configure
@@ -2353,7 +2353,7 @@ msvc_common_flags(){
-std=c99) ;;
# Common flags
- -fomit-frame-pointer) echo -Oy ;;
+ -fomit-frame-pointer) ;;
-g) echo -Z7 ;;
-fno-math-errno) ;;
@@ -3947,6 +3947,7 @@ elif enabled pathscale; then
elif enabled_any msvc icl; then
enabled x86_32 && disable aligned_stack
+ enabled_all x86_32 debug && add_cflags -Oy-
This changes the semantics of --disable-optimizations, which will no longer
disable this flag.
How so?
Oy is implicit in both O1 and O2, and MSVC does not build at all
without O1 or O2 because there is no dead code elimination otherwise.
So i fail to see what it changes, except that it changes what it says
- disable Oy in debug mode, because debugging without frame pointers
is just silly.
The reason the first part is required is because you can only
explicitly disable Oy if it wasn't explicitly enabled before.
I think we have two issues here: debug mode and optimized mode.
Filtering out -fomit-frame-pointer in optimized mode seems to make
sense. However, I'm not convinced that adding -Oy- in debug mode is
equivalent to what we do for other compilers in debug mode.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
