On Sun, Jun 23, 2013 at 08:50:30AM +0200, Luca Barbato wrote:
> From: Michael Niedermayer <[email protected]>
> 
> This fixes a TODO item and unifies both decoders structures
> It also fixes undefined behavior due to aliasing violations
> 
> I choose 2 fields instead of a union because mistakely using the
> wrong type with a union will lead to hard to debug "wrong output"
> while with 2 fields mistakely using the wrong type will crash
> with a null pointer derefernce which is much easier to debug

OMG, if the English police sees this...

I think I disagree; a union would be cleaner and avoid special cases
and casts.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to