On Fri, Jun 28, 2013 at 06:53:31AM +0200, Luca Barbato wrote:
> Prevent horrid and hard to trace struct overwrite.
> 
> Reported-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
> CC: libav-sta...@libav.org
> ---
>  libavcodec/wmaprodec.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c
> index 6a64641..0712fb7 100644
> --- a/libavcodec/wmaprodec.c
> +++ b/libavcodec/wmaprodec.c
> @@ -1459,6 +1459,14 @@ static void save_bits(WMAProDecodeCtx *s, 
> GetBitContext* gb, int len,
>          return;
>      }
>  
> +    if (len > put_bits_left(&s->pb)) {
> +        av_log(s->avctx, AV_LOG_ERROR,
> +               "Cannot append %d bits, %d bits available\n",

Cannot append %d bits, only %d bits are available?

> +               len, put_bits_left(&s->pb));
> +        s->packet_loss = 1;
> +        return;
> +    }
> +
>      s->num_saved_bits += len;
>      if (!append) {
>          avpriv_copy_bits(&s->pb, gb->buffer + (get_bits_count(gb) >> 3),
> -- 

probably OK
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to