On Fri, Jul 19, 2013 at 09:19:54AM +0200, Kostya Shishkov wrote: > --- > libavcodec/Makefile | 2 +- > libavcodec/twinvq.c | 662 > +------------------------------------------- > libavcodec/twinvq_common.c | 562 +++++++++++++++++++++++++++++++++++++ > libavcodec/twinvq_common.h | 160 +++++++++++ > 4 files changed, 732 insertions(+), 654 deletions(-) > create mode 100644 libavcodec/twinvq_common.c > create mode 100644 libavcodec/twinvq_common.h
Why not call the decoder twinvqdec.c and keep the common code in twinvq.c? This appears more in line with what we do in other places. > --- /dev/null > +++ b/libavcodec/twinvq_common.h > @@ -0,0 +1,160 @@ > + > +#ifndef AVCODEC_TWINVQ_COMMON_H > +#define AVCODEC_TWINVQ_COMMON_H > + > +#include <math.h> > +#include <stdint.h> > +#include "libavutil/common.h" > +#include "libavutil/float_dsp.h" > +#include "avcodec.h" > +#include "fft.h" Please add an empty line between system and local headers. > +void twinvq_decode_lsp(TwinContext *tctx, int lpc_idx1, uint8_t *lpc_idx2, > + int lpc_hist_idx, float *lsp, float *hist); > +void twinvq_dec_lpc_spectrum_inv(TwinContext *tctx, float *lsp, > + enum FrameType ftype, float *lpc); > +void twinvq_imdct_output(TwinContext *tctx, enum FrameType ftype, int wtype, > + float **out); > +av_cold int twinvq_init_mdct_win(TwinContext *tctx); > +av_cold void twinvq_init_bitstream_params(TwinContext *tctx, int > is_metasound); > +av_cold int twinvq_decode_close(AVCodecContext *avctx); missin ff_ prefix Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
