On 07/20/2013 02:50 PM, Derek Buitenhuis wrote: > On 7/19/2013 3:20 PM, Luca Barbato wrote: >> Adding a -DX264_API_IMPORTS=1 would probably make them calmer? > > I'm not terribly fond of spamming this libx264-specific define in our > CPPFLAGS... it seems like a rather messy alternative to a nicely > cohesive patch as-is. Of course, others' opinions are welcome -- I > will do what the majority want.
Personally I do not mind either elif enabled_any msvc icl; then +enabled libx264 && add_cppflags -DX264_API_IMPORTS=1 is a single line but spams the definition all over while + +#if defined(_MSC_VER) +#define X264_API_IMPORTS 1 +#endif + doesn't spam around but adds system specific code in a file that should stay generic if possible. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
