On 24/07/13 15:26, Martin Storsjö wrote: > On Wed, 24 Jul 2013, Luca Barbato wrote: > >> On 24/07/13 11:52, Martin Storsjö wrote: >>> From: Michael Niedermayer <[email protected]> >>> >>> Chapter ids need to start from 1 or higher in matroska. If >>> necessary, offset the chapter ids to the valid range. >>> >>> Based on a patch by Fabian Neundorf. >>> --- >>> Compared to the previous patch, this keeps the chapter ids intact >>> if remuxing from matroska (or any other source where the ids are >>> in the correct range to begin with). >> >> Feels in the wrong place if we have other formats with the same problem, > > That's certainly a valid point
But I guess none of us know by heart or has time to check which does what. > Hmm, I'm not sure I'd agree with you there, and I think your snippet has > got a bit too many typos to figure out what you mean that it would do. > (The solution in the patch also handles negative chapter ids, if that > ever were to happen, FWIW.) Negative chapters sound even more wrong. > Anyway, I'm not all that much into chapters, so if you want to solve it > in other ways, I'll drop this patch and let you finish it. I'm a bit too busy this week. If you need this landing soon I can try to carve 5 minutes to get the bulk of it or just commit it. I do not have samples handy to check that. lu _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
