On Wed, 31 Jul 2013, Anton Khirnov wrote:


On Wed, 31 Jul 2013 13:50:01 +0300, Martin Storsjö <[email protected]> wrote:
Previously you couldn't set them back to NULL, only to a zero-length
string. Now it's only disallowed to pass NULL when setting numeric
options.
---
 libavutil/opt.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)


Does this fix some real problem?

I kind of like to keep the distinction between NULL and an empty string in certain cases, but nothing that strictly requires supporting NULL right now.

I vaguely recall some code assuming string AVOptions will never be NULL if the
default is set.

Hmm, ok. If you get to looking into this area again, it'd be nice if you could reconfirm this then, or see if it can be allowed. I can defer the patch for now at least.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to