On Mon, Aug 05, 2013 at 05:23:59AM +0200, Luca Barbato wrote:
> On 05/08/13 00:52, Diego Biurrun wrote:
> > On Sun, Aug 04, 2013 at 05:34:41PM +0200, Luca Barbato wrote:
> >> --- /dev/null
> >> +++ b/libavcodec/qsv.c
> >> @@ -0,0 +1,377 @@
> >> +
> >> +int ff_qsv_init(AVCodecContext *c, QSVContext *q)
> >> +{
> >> + int ret;
> >> + mfxIMPL impl = MFX_IMPL_AUTO_ANY;
> >> + mfxVersion ver = { { QSV_VERSION_MINOR, QSV_VERSION_MAJOR }
> >> };
> >
> > This is the only place where ..
> >
> >> --- /dev/null
> >> +++ b/libavcodec/qsv.h
> >> @@ -0,0 +1,63 @@
> >> +
> >> +#define QSV_VERSION_MAJOR 1
> >> +#define QSV_VERSION_MINOR 6
> >
> > .. these defines are used. I don't see why they should be exposed.
>
> Magic numbers are bad
Sure, but they don't need to be exposed in the .h file if they are only
used in the .c file.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
